New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove expired DST Root CA X3 #31219
Conversation
Failing test are unrelated, merging |
Release Notes Persisted
|
Would it be possible to make an Electron 14 release with this patch? Or is the following patch that got reverted sufficient? #31216 |
The fix available via |
Thanks for the clarification, @deepak1556. I'm currently running 13.5.1 and it seems like the bug is also fixed with #31216. But a user reported error: |
@quanglam2807 can you open an issue with minimal repro, it would help to confirm if there was a regression. If repro is not available, can you collect the network trace by launching the app with |
@deed02392 I'm sorry but I couldn't reproduce the bug on my Mac and the user is not technical-savvy so it'd be difficult to ask for the network trace. If I upgrade from electron@13.5.1 to electron@15.1.1 and it works, maybe we can then make the conclusion? Or is anything better I can do? |
Description of Change
Alternative targeted fix for stable branch lines while the boringssl change is explored in main and beta branches.
Refs https://bugs.chromium.org/p/boringssl/issues/detail?id=439#c2
Checklist
npm test
passesRelease Notes
Notes: Remove expired DST Root CA X3 from the bundled trust store